Fixing some snippets in rename.py #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made : 1. The arguments could easily be fetched by unpacking the argv variable and assigning them directly to the corresponding variables. It seems more clearer that way. 2. I am so happy to see such good and enthusiastic comments in code. It seems more cool to usually indent the comments of a continuous block according to the longest line and then aligning others accordingly. But it becomes tedious task in large files, so ill be writing a script for that too :D
sarmahsubhan
added a commit
to sarmahsubhan/Python
that referenced
this pull request
Jun 17, 2017
Someone suggested me not to use while too much, so tried to create an alternative. I am a newbie and this is my first contribution! A line in the previous code (The equivalent to which in the current code is line geekcomputers#26 said [10], which should have been [12], please fix it. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made :
But it becomes tedious task in large files, so ill be writing a script for that too :D