Skip to content

Catalog status#1119

Merged
offtherailz merged 4 commits into
masterfrom
catalog_status
Oct 11, 2016
Merged

Catalog status#1119
offtherailz merged 4 commits into
masterfrom
catalog_status

Conversation

@saidaipparla

Copy link
Copy Markdown
Contributor

added action "RESET_STATUS" when the Catalog Widget is closed

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 80.46% when pulling 868ffa8 on catalog_status into cb2d38a on master.

right: 200px;
margin-top: 100px;
display: inline-block;
margin: 100PX;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still wrong case.

Comment thread web/client/actions/catalog.js Outdated
const RECORD_LIST_LOAD_ERROR = 'RECORD_LIST_LOAD_ERROR';
const CHANGE_CATALOG_FORMAT = 'CHANGE_CATALOG_FORMAT';
const ADD_LAYER_ERROR = 'ADD_LAYER_ERROR';
const RESET_STATUS = 'RESET_STATUS';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too generic. You can call the variable RESET_STATUS but the string should be unique, lets say CATALOG_RESET

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 80.546% when pulling be9b266 on catalog_status into cb2d38a on master.

@offtherailz offtherailz merged commit 451d9c1 into master Oct 11, 2016
@offtherailz offtherailz deleted the catalog_status branch October 14, 2016 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants