fix #1151 fixed some warnings#1226
Conversation
mbarto
left a comment
There was a problem hiding this comment.
Are there any remaining warnings?
| if (this.props.metadataModal) { | ||
| let MetadataModal = this.props.metadataModal; | ||
| return (<MetadataModal ref="metadataModal" show={this.props.currentMap && this.props.currentMap.displayMetadataEdit} onHide={this.props.resetCurrentMap} | ||
| return (<MetadataModal key="metadataModal" show={this.props.currentMap && this.props.currentMap.displayMetadataEdit} onHide={this.props.resetCurrentMap} |
There was a problem hiding this comment.
You cannot remove the ref, it's used
There was a problem hiding this comment.
ok i will keep ref and add key
| onGoToMap: React.PropTypes.func, | ||
| colProps: React.PropTypes.object, | ||
| isLoggedIn: React.PropTypes.bool | ||
| isLoggedIn: React.PropTypes.object |
There was a problem hiding this comment.
bool is correct. You need to change the connect to set a bool value
| return { | ||
| mapType: "leaflet", | ||
| isLoggedIn: false, | ||
| isLoggedIn: "", |
There was a problem hiding this comment.
ok i will change this
|
yes as far i have seen there are other two warnings
|
|
Ok, then fix also the two remaining warnings |
|
Is the "when we will click on settings icon in layer properties" still there? |
| CreateNewMapPlugin: connect((state) => ({ | ||
| mapType: (state.maps && state.maps.mapType) || (state.home && state.home.mapType), | ||
| isLoggedIn: state && state.security && state.security.user | ||
| isLoggedIn: state && state.security && state.security.user && state.security.user.enabled |
There was a problem hiding this comment.
isLoggedIn: state && state.security && state.security.user && true || false
There was a problem hiding this comment.
ok i will change
| "submitConfig": { | ||
| "buttonConfig": { | ||
| "bsSize": "medium", | ||
| "bsSize": "small", |
There was a problem hiding this comment.
Have you checked that the button doesn't change?
There was a problem hiding this comment.
yes i checked its changed
No description provided.