#12555 WFS export by current viewport doesn't work as expected#12557
Open
Binabh wants to merge 7 commits into
Open
#12555 WFS export by current viewport doesn't work as expected#12557Binabh wants to merge 7 commits into
Binabh wants to merge 7 commits into
Conversation
1 task
dsuren1
requested changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
@Binabh
Lood good overall but I noticed few cases where the import doesn't work as expected, could please check. Thanks!
WFS (Shapefile)
- Without crop to viewport, upon importing the shaptefile, a warning
The file {{name}} cannot be imported because it does not fit the map boundariesis shown and import fails - With Crop to viewport, the imported feature shown on map is incorrect. Use the map in the issue
Contributor
Author
|
@dsuren1 thank you for your review. I will look into the case you reported and push a fix in a while. |
Contributor
Author
|
@dsuren1 the issue related to import failing was related to projection mismatch rather than crop features. When data was exported using native CRS rather than wgs84 then this error was happening. I have pushed the fix. Please review it and let me know if any further improvements are required. |
Member
|
@dsuren1 waiting for your new review here. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Even if
Crop dataset to current viewportturned on for WFS layer the cropping of download features was not happening properly because the proper OGC filter was not being passed. So, the feature was not working properly.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#12555
What is the new behavior?
Now OCG filter of intersect is applied to if
Crop dataset to current viewportis turned on. This sends valid OCG filter to crop the data. If option is not checked the behavior is same as before.Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)