Skip to content

Fix bbox format in ZOOM_TO_EXTENT reducer#1277

Merged
mbarto merged 1 commit into
geosolutions-it:masterfrom
sourcepole:zoomtoextent
Nov 16, 2016
Merged

Fix bbox format in ZOOM_TO_EXTENT reducer#1277
mbarto merged 1 commit into
geosolutions-it:masterfrom
sourcepole:zoomtoextent

Conversation

@manisandro

Copy link
Copy Markdown
Contributor

As far as I can see, various components use/expect the bbox format in the map state to be

map {
 bbox:
  bounds: {
   minx: ...,
   miny: ...,
   maxx: ...,
   maxy: ...
 }
}

The ZOOM_TO_EXTENT reducer however writes a bbox in the format:

map {
 bbox: [minx, miny, maxx, maxy]
}

This can break various things, for instance rotation (since rotation is stored as a field in bbox).

@simboss simboss added the ready label Nov 15, 2016
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.005%) to 80.011% when pulling b945a50 on sourcepole:zoomtoextent into b5b3eb1 on geosolutions-it:master.

@mbarto mbarto merged commit e753ffc into geosolutions-it:master Nov 16, 2016
@mbarto mbarto removed the ready label Nov 16, 2016
@manisandro manisandro deleted the zoomtoextent branch November 16, 2016 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants