Skip to content

Add point measurement support#1339

Merged
mbarto merged 1 commit into
geosolutions-it:masterfrom
sourcepole:pointmeasure
Dec 13, 2016
Merged

Add point measurement support#1339
mbarto merged 1 commit into
geosolutions-it:masterfrom
sourcepole:pointmeasure

Conversation

@manisandro

Copy link
Copy Markdown
Contributor

Adds a measurement mode for measuring point coordinates.

@simboss simboss added the ready label Dec 8, 2016
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 80.137% when pulling c3d4101 on sourcepole:pointmeasure into bdeb615 on geosolutions-it:master.

areaMeasureEnabled: this.props.measurement.areaMeasureEnabled,
bearingMeasureEnabled: this.props.measurement.bearingMeasureEnabled,
geomType: this.props.measurement.geomType,
point: null, // handled in onDraw.created

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we also need a pointMeasureEnabled: ... here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, commit amended. BTW I'll have a followup PR which will clean up the code a bit.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 80.1% when pulling 57cbf15 on sourcepole:pointmeasure into 7c110f9 on geosolutions-it:master.

@mbarto mbarto merged commit e937622 into geosolutions-it:master Dec 13, 2016
@mbarto mbarto removed the ready label Dec 13, 2016
@manisandro manisandro deleted the pointmeasure branch December 13, 2016 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants