Skip to content

Also update measurements on mouse move#1350

Merged
mbarto merged 2 commits into
geosolutions-it:masterfrom
sourcepole:measure_on_mouse_move
Dec 13, 2016
Merged

Also update measurements on mouse move#1350
mbarto merged 2 commits into
geosolutions-it:masterfrom
sourcepole:measure_on_mouse_move

Conversation

@manisandro

Copy link
Copy Markdown
Contributor

Also update the measurement values while moving the mouse. Includes some code cleanups along the way.

@simboss simboss added the ready label Dec 13, 2016
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 80.194% when pulling 520e815 on sourcepole:measure_on_mouse_move into a02f82f on geosolutions-it:master.

@mbarto mbarto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the update on mouse move optional and disabled by default?

@manisandro

manisandro commented Dec 13, 2016

Copy link
Copy Markdown
Contributor Author

Uhm, it's a bit hard to inject properties into the MeasurementSupport components from the global config. Or shall I abuse state.measurement for this (i.e. state.measurement.updateOnMousemove)?

@mbarto

mbarto commented Dec 13, 2016

Copy link
Copy Markdown
Contributor

You should be able to use the Map plugin toolsOptions property to pass down properties to the tool

@manisandro

Copy link
Copy Markdown
Contributor Author

Ah missed that one, I'll have a look, thanks.

@manisandro manisandro force-pushed the measure_on_mouse_move branch from dd3e1ba to a3a2f5c Compare December 13, 2016 16:27
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 80.072% when pulling a3a2f5c on sourcepole:measure_on_mouse_move into fd359ef on geosolutions-it:master.

@mbarto mbarto merged commit a8de3e5 into geosolutions-it:master Dec 13, 2016
@mbarto mbarto removed the ready label Dec 13, 2016
@manisandro manisandro deleted the measure_on_mouse_move branch December 13, 2016 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants