Fix #1392 added viewport into spatial filter list#1822
Merged
Conversation
mbarto
suggested changes
May 12, 2017
| }; | ||
| } | ||
|
|
||
| function selectViewportSM() { |
Contributor
There was a problem hiding this comment.
don't be shy, selectViewportSpatialMethod
| onChangeDrawingStatus: () => {}, | ||
| onRemoveSpatialSelection: () => {}, | ||
| onShowSpatialSelectionDetails: () => {}, | ||
| onSelectViewportSM: () => {}, |
| } | ||
|
|
||
| function query(searchUrl, filterObj, retry) { | ||
| function query(searchUrl, filterObj) { |
Contributor
Author
There was a problem hiding this comment.
nope, it's been removed in getFeatures method of DockerFeatureGrid component
| action$.ofType(SELECT_VIEWPORT_SPATIAL_METHOD, CHANGE_MAP_VIEW) | ||
| .switchMap((action) => { | ||
| // calculate new geometry from map properties | ||
| const map = action.type === CHANGE_MAP_VIEW ? action : store.getState().map.present; |
Contributor
There was a problem hiding this comment.
are you updating the geometry also if the spatial filter is not Viewport?
mbarto
approved these changes
May 15, 2017
offtherailz
approved these changes
May 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Viewport optios has been added to the spatial filter list.
Every time the view changes the geometry of the filterObj updates with an epic.