#9806: Do not visualize map sync popup by default for attribute table#9813
Merged
Conversation
…attribute table Description: - Add cfg in localConfig file for FeatureEditor plugin called showPopoverSync and set its value by false - Handle logic to read the cfg showPopoverSync into toolbar component to hide/show popup map sync initially - Clean the unused code related the previous approach that was handling popup map sync - Add the required unit tests - Document the new implemented cfg in /plugins/featuregrid/FeatureEditor.jsx, /plugins/FeatureEditor.jsx files
6 tasks
…Attribute Table Description: - resolve FE test failure
MV88
requested changes
Dec 14, 2023
MV88
left a comment
Contributor
There was a problem hiding this comment.
functionality and code wise all good.
only a little change on the localConfig.json file
…quick filter Description: - resolve review comments by reset localConfig - put default value for showPopoverSync within pluginCfg of FeatureEditor
…quick filter Description: - resolve FE test failure
MV88
approved these changes
Dec 15, 2023
Contributor
|
@ElenaGallo please test it in DEV |
Contributor
|
Test passed, @mahmoudadel54 please backport to 2023.02.xx. Thanks |
Contributor
Author
Backport is done ---> #9833 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, not visualizing map sync popup by default for the attribute table has been handled including the following:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9806
What is the current behavior?
#9806
What is the new behavior?
The map sync popup is not open by default if user open the attribute table by adding showPopoverSync by false value in localConfig file.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)