Skip to content

#9823: Fix - [Annotations] Disabled annotations are printed#9837

Merged
offtherailz merged 2 commits into
geosolutions-it:2023.02.xxfrom
dsuren1:#9823_fix
Jan 8, 2024
Merged

#9823: Fix - [Annotations] Disabled annotations are printed#9837
offtherailz merged 2 commits into
geosolutions-it:2023.02.xxfrom
dsuren1:#9823_fix

Conversation

@dsuren1

@dsuren1 dsuren1 commented Dec 19, 2023

Copy link
Copy Markdown
Contributor

Description

This PR excludes features hidden in annotation layers from getting printed

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?
The hidden features of annotation layers are not printed

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code LGTM. Didn't tested, but I'll code looks ok.

@tdipisa tdipisa added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jan 8, 2024
@offtherailz

Copy link
Copy Markdown
Member

@ElenaGallo, could you please test this on DEV when deployed ? Thank you

@offtherailz offtherailz merged commit 1518651 into geosolutions-it:2023.02.xx Jan 8, 2024
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 8, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 10, 2024
@ElenaGallo

Copy link
Copy Markdown
Contributor

Test passed, @dsuren1 please backport to the 2023.02.xx. Thanks

@dsuren1

dsuren1 commented Jan 11, 2024

Copy link
Copy Markdown
Contributor Author

@ElenaGallo This has to be tested in QA as this PR merges the fix directly to stable. Thanks!

landryb added a commit to landryb/MapStore2 that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Annotations] Disabled annotations are printed [Annotations] Disabled annotations are printed

4 participants