Skip to content

#9586 - Persist timeline animation settings when saving a map#9865

Merged
MV88 merged 1 commit into
geosolutions-it:masterfrom
dsuren1:#9586_playback_save
Jan 11, 2024
Merged

#9586 - Persist timeline animation settings when saving a map#9865
MV88 merged 1 commit into
geosolutions-it:masterfrom
dsuren1:#9586_playback_save

Conversation

@dsuren1

@dsuren1 dsuren1 commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Description

This PR saves the playback timeline settings when saving a map and initializes the playback data on map config load

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?

  • Persist timeline settings by saving the data on map save
  • Initializes the playback data on map config load

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added enhancement Support Timeline BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C027-COMUNE_FI-2023-SUPPORT labels Jan 10, 2024
@dsuren1 dsuren1 added this to the 2023.02.02 milestone Jan 10, 2024
@dsuren1 dsuren1 requested a review from offtherailz January 10, 2024 13:54
@dsuren1 dsuren1 self-assigned this Jan 10, 2024
@dsuren1 dsuren1 linked an issue Jan 10, 2024 that may be closed by this pull request
6 tasks
@tdipisa tdipisa requested review from MV88 and removed request for offtherailz January 10, 2024 14:00

@MV88 MV88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MV88 MV88 merged commit 254dcc2 into geosolutions-it:master Jan 11, 2024
@MV88

MV88 commented Jan 11, 2024

Copy link
Copy Markdown
Contributor

@ElenaGallo Please test it in DEV

@tdipisa

tdipisa commented Jan 11, 2024

Copy link
Copy Markdown
Member

@ElenaGallo let us know for the backport

@ElenaGallo

Copy link
Copy Markdown
Contributor

Test passed, @dsuren1 please backport to 2023.02.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Jan 12, 2024
tdipisa pushed a commit that referenced this pull request Jan 12, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persist timeline animation settings when saving a map

4 participants