This repository was archived by the owner on Aug 30, 2023. It is now read-only.
fix: timestamp with millis from react-native should be in UTC format#456
Merged
marandaneto merged 2 commits intoJun 14, 2020
Conversation
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
=========================================
Coverage 60.26% 60.26%
Complexity 816 816
=========================================
Files 93 93
Lines 3727 3727
Branches 359 359
=========================================
Hits 2246 2246
Misses 1328 1328
Partials 153 153
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Jun 12, 2020
…idSerializerTest.kt Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
fix: timestamp with millis from react-native should be already in UTC format
💡 Motivation and Context
timestamps were off in react-native events if not UTC.
💚 How did you test it?
unit test.
📝 Checklist
🔮 Next steps
release a new sentry-react-native version.