This repository was archived by the owner on Aug 30, 2023. It is now read-only.
fix: converting UTC and ISO timestamp when missing Locale/TimeZone do not error#505
Merged
marandaneto merged 2 commits intoAug 4, 2020
Conversation
bruno-garcia
approved these changes
Aug 3, 2020
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
Follow up PR (after hackweek for example) would be to handle when date is null. We should't do sessions at all at least in that case
|
|
||
| duration = calculateDurationTime(this.timestamp); | ||
| sequence = getSequenceTimestamp(this.timestamp); | ||
| if (this.timestamp != null) { |
Member
There was a problem hiding this comment.
Likely worth not having sessions enabled at all for this device since they'll be broken
Contributor
Author
There was a problem hiding this comment.
yep, SessionAdapter will drop on deserialization at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
fix: converting UTC and ISO timestamp when missing Locale/TimeZone do not error
💡 Motivation and Context
Andromax G36C1H
Smartfren Andromax AD6B1H
Andromax C46B2H
devices have problems with getting US locale or UTC/GTM time zones.
💚 How did you test it?
I can't really test it, I don't have those devices nor found emulators.
📝 Checklist
🔮 Next steps