Skip to content

ci: align build-wasm node setup to setup-node@v6 / Node 24#41243

Merged
pelikhan merged 4 commits into
mainfrom
copilot/ci-coach-align-build-wasm-node-setup
Jun 24, 2026
Merged

ci: align build-wasm node setup to setup-node@v6 / Node 24#41243
pelikhan merged 4 commits into
mainfrom
copilot/ci-coach-align-build-wasm-node-setup

Conversation

Copilot AI commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The build-wasm job in cgo.yml was the last outlier using actions/setup-node@v4 with Node 20, while every other Node.js step across ci.yml and cjs.yml already uses setup-node@v6 with Node 24.

Changes

  • cgo.yml: Update the build-wasm "Set up Node.js" step from setup-node@cdca736 (v4) + node 20setup-node@395ad32 (v6) + node 24

Generated by 👨‍🍳 PR Sous Chef · 92.1 AIC · ⌖ 1.08 AIC · ⊞ 17.6K ·

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Align build-wasm Node.js setup to v6/node24 ci: align build-wasm node setup to setup-node@v6 / Node 24 Jun 24, 2026
Copilot AI requested a review from pelikhan June 24, 2026 15:36
@pelikhan pelikhan marked this pull request as ready for review June 24, 2026 17:04
Copilot AI review requested due to automatic review settings June 24, 2026 17:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the build-wasm job’s Node.js setup in .github/workflows/cgo.yml with the rest of the repository’s CI configuration by moving off actions/setup-node@v4/Node 20 and standardizing on actions/setup-node@v6/Node 24.

Changes:

  • Update build-wasm to use actions/setup-node@395ad326... (v6).
  • Bump node-version from 20 to 24 for the wasm golden tests run via Node.
Show a summary per file
File Description
.github/workflows/cgo.yml Updates the build-wasm job’s Node.js setup to setup-node@v6 and Node 24 to match the rest of CI.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #41243 does not have the 'implementation' label and has 0 new lines of code in business logic directories (≤100 threshold). Only 1 file changed.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Only .github/workflows/cgo.yml was changed (CI workflow alignment). Test Quality Sentinel skipped.

@github-actions

Copy link
Copy Markdown
Contributor

@copilot refresh the branch and rerun checks after syncing with base.

Generated by 👨‍🍳 PR Sous Chef · 92.1 AIC · ⌖ 1.08 AIC · ⊞ 17.6K ·

@github-actions github-actions Bot mentioned this pull request Jun 24, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /zoom-out — change looks good and correctly aligns the last outlier.

📋 Key Themes & Highlights

Key Themes

  • Consistency alignment: build-wasm was the only job still on setup-node@v4 / Node 20. This PR eliminates that last discrepancy.
  • SHA verified: 395ad3262231945c25e8478fd5baf05154b1d79f is already pinned in ci.yml (line 428) and across all cjs.yml jobs — the new value is a copy-paste from live, working CI, not a freshly-introduced dependency.
  • Wasm script compatibility: scripts/test-wasm-golden.mjs uses only stable built-in Node.js APIs (fs, path, child_process, module) — no packages that could break on Node 24.

Positive Highlights

  • ✅ Minimal, surgical change — exactly 2 lines, 1 file
  • ✅ SHA pin is consistent with the rest of the repo (no version drift)
  • ✅ Clear PR description explaining the motivation

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 30.4 AIC · ⌖ 7.47 AIC · ⊞ 6.5K

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues — clean alignment change

2-line CI housekeeping: bumps the build-wasm job's Node.js step from setup-node@v4/Node 20 to setup-node@v6/Node 24, eliminating the last outlier in the repo.

Review notes
  • SHA correctness: 395ad3262231945c25e8478fd5baf05154b1d79f is identical to every other setup-node reference across ci.yml, cjs.yml, and the other step in cgo.yml.
  • Node 24 compatibility: test-wasm-golden.mjs runs a WASM binary via Node — Node 24 is fully backward-compatible here and already validated in all other jobs.
  • No cache needed: This step skips cache: npm deliberately — there is no npm install preceding it.
  • Minor (non-blocking): node-version: '24' uses single-quotes while the other step in the same file uses double-quotes.

🔎 Code quality review by PR Code Quality Reviewer · 42.6 AIC · ⌖ 6.99 AIC · ⊞ 5.2K

@pelikhan pelikhan merged commit fcfef71 into main Jun 24, 2026
15 of 16 checks passed
@pelikhan pelikhan deleted the copilot/ci-coach-align-build-wasm-node-setup branch June 24, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants