fix(go-logger): restore daily schedule runs broken since June 5#41362
Merged
Conversation
…ys skipped Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…workflow Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
June 25, 2026 04:28
View session
pelikhan
approved these changes
Jun 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores scheduled executions for the go-logger agent workflow by removing an unsatisfiable activation job condition that referenced a non-existent pre_activation job output. This aligns go-logger with how gh-aw actually compiles top-level frontmatter steps: (as agent pre-steps, not a separate pre-activation job).
Changes:
- Remove the
activationgating condition and the unusedjobs: pre-activation:frontmatter block fromgo-logger.md. - Recompile
go-logger.lock.ymlsoactivationno longer includes the brokenif:condition. - Update
design-decision-gate.lock.ymlas part of recompile output (includes model metadata/model env rendering changes).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/go-logger.md | Removes invalid/ineffective pre-activation gating that caused scheduled runs to be skipped. |
| .github/workflows/go-logger.lock.yml | Regenerates the compiled workflow so activation is no longer permanently skipped. |
| .github/workflows/design-decision-gate.lock.yml | Recompiled output change affecting model metadata / GH_AW_INFO_MODEL rendering (not mentioned in PR description). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
Comment on lines
+1
to
2
| # gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"f9b7689b25bfd2258e1244d47179c99e2373461d1611ef70ac604a6bbb81d0bd","body_hash":"7e583643f095382493209c5ecbcb97e582f922d97b58574d6cfdacdf33fbf79b","strict":true,"agent_id":"claude","agent_model":"claude-sonnet-4-6","engine_versions":{"claude":"2.1.191"}} | ||
| # gh-aw-manifest: {"version":1,"secrets":["ANTHROPIC_API_KEY","GH_AW_CI_TRIGGER_TOKEN","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GH_AW_OTEL_GRAFANA_AUTHORIZATION","GH_AW_OTEL_GRAFANA_ENDPOINT","GH_AW_OTEL_SENTRY_AUTHORIZATION","GH_AW_OTEL_SENTRY_ENDPOINT","GITHUB_TOKEN"],"actions":[{"repo":"actions/cache/restore","sha":"27d5ce7f107fe9357f9df03efb73ab90386fccae","version":"v5.0.5"},{"repo":"actions/cache/save","sha":"27d5ce7f107fe9357f9df03efb73ab90386fccae","version":"v5.0.5"},{"repo":"actions/checkout","sha":"9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0","version":"v7.0.0"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-node","sha":"48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.27.10","digest":"sha256:e47878fa4953f5b4d38b4ec12c155aa12ab9befea299ea2d21a8b104de8bcbc8","pinned_image":"ghcr.io/github/gh-aw-firewall/agent:0.27.10@sha256:e47878fa4953f5b4d38b4ec12c155aa12ab9befea299ea2d21a8b104de8bcbc8"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.10","digest":"sha256:4bd2598466928efbd360fd6575b68c6b420a7ec3b7c1be20844c560a0dd2878e","pinned_image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.10@sha256:4bd2598466928efbd360fd6575b68c6b420a7ec3b7c1be20844c560a0dd2878e"},{"image":"ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.10"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.27.10","digest":"sha256:4d7a79482c47f2390f9fa87663cd9cb728bfb2380d9a9610479fa234c906ea98","pinned_image":"ghcr.io/github/gh-aw-firewall/squid:0.27.10@sha256:4d7a79482c47f2390f9fa87663cd9cb728bfb2380d9a9610479fa234c906ea98"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.30","digest":"sha256:4d0101d8740c99b755181d19dc0067ac7eb40433d1c354fd715358bee4a296c1","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.30@sha256:4d0101d8740c99b755181d19dc0067ac7eb40433d1c354fd715358bee4a296c1"},{"image":"ghcr.io/github/gh-aw-node","digest":"sha256:529d02eb970b1161aa25c593a9c3df57fdfad5a8add328cb3b6eccef66f3183b","pinned_image":"ghcr.io/github/gh-aw-node@sha256:529d02eb970b1161aa25c593a9c3df57fdfad5a8add328cb3b6eccef66f3183b"},{"image":"ghcr.io/github/github-mcp-server:v1.4.0","digest":"sha256:2afb26356481d1a350e14544a6e160f7f7ec1561a1ea309b823665abf0309036","pinned_image":"ghcr.io/github/github-mcp-server:v1.4.0@sha256:2afb26356481d1a350e14544a6e160f7f7ec1561a1ea309b823665abf0309036"}]} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
f4404c3d52addedif: needs.pre_activation.outputs.should_run == 'true'to theactivationjob, but the compiler never generates apre_activationjob from top-levelsteps:in frontmatter — soneeds.pre_activation.outputs.should_runalways evaluates to'', causingactivationto be permanently skipped onscheduleevents. All 20 runs since June 5 haveconclusion: skipped.Changes
go-logger.md: Remove the brokenif:andjobs: pre-activation:frontmatter fields. Thelogger_manifestpre-step remains in theagentjob and continues producingpreflight.jsonfor the agent to consult; thenoopsafe-output handles the "nothing changed" case.go-logger.lock.yml: Recompiled —activationno longer carries the unsatisfiable condition.Why the pattern was wrong
Other workflows that correctly generate a
pre_activationjob (e.g.daily-cli-performance.md) neststeps:underon:, not at the frontmatter top level. Top-levelsteps:are injected into theagentjob's pre-steps, sojobs: pre-activation:in the frontmatter compiled to nothing, leavingactivationgating on a phantom job output.