Require explicit safe output completion in daily compiler quality workflow#41841
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix daily compiler quality check no safe outputs issue
Require explicit safe output completion in daily compiler quality workflow
Jun 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the daily compiler quality workflow’s safe-output contract so runs end with an explicit, recordable outcome (either publishing a discussion report or explicitly doing nothing via noop), and adds a regression test to keep the contract stable across compilation.
Changes:
- Adds a
noopentry to the workflow’ssafe-outputsblock to explicitly support “no action” outcomes. - Strengthens the workflow prompt to require finishing with either
create_discussionornoop(never plain text only). - Adds a focused Go test to assert the source workflow declares
noopand the compiled lockfile still wires safe-output tooling as expected.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/daily_compiler_quality_workflow_test.go |
Adds a regression test that validates the workflow source + compiled lockfile include the expected safe-output contract. |
.github/workflows/daily-compiler-quality.md |
Declares noop as an allowed safe-output and adds an explicit end-of-run guardrail in the prompt. |
.github/workflows/daily-compiler-quality.lock.yml |
Updates the compiled workflow lock output to reflect the updated workflow contract. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Low
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily compiler quality workflow could complete successfully without emitting any safe output, which left the run with no discussion, no noop, and no recorded outcome. This change tightens the workflow contract so the agent must end with an explicit safe-output action.
Workflow contract
noopto the workflow'ssafe-outputsblock so a no-action outcome is explicitly supported.create-discussionas the primary path, withnoopas the fallback when no valid report should be published.Prompt guardrail
create_discussionornoop.noopimmediately instead.Coverage
noop