Skip to content

Require explicit safe output completion in daily compiler quality workflow#41841

Merged
pelikhan merged 2 commits into
mainfrom
copilot/debug-daily-compiler-check
Jun 27, 2026
Merged

Require explicit safe output completion in daily compiler quality workflow#41841
pelikhan merged 2 commits into
mainfrom
copilot/debug-daily-compiler-check

Conversation

Copilot AI commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

The daily compiler quality workflow could complete successfully without emitting any safe output, which left the run with no discussion, no noop, and no recorded outcome. This change tightens the workflow contract so the agent must end with an explicit safe-output action.

  • Workflow contract

    • Add noop to the workflow's safe-outputs block so a no-action outcome is explicitly supported.
    • Keep create-discussion as the primary path, with noop as the fallback when no valid report should be published.
  • Prompt guardrail

    • Strengthen the final output instructions to require the agent to finish with either create_discussion or noop.
    • Make the fallback behavior explicit: if the run would otherwise end with plain text only, emit noop immediately instead.
  • Coverage

    • Add a focused workflow test that asserts:
      • the source workflow declares noop
      • the compiled workflow still exposes the expected safe-output tool wiring
safe-outputs:
  create-discussion:
    category: audits
    close-older-discussions: true
    expires: 1d
    fallback-to-issue: true
    max: 1
    min-body-length: 200
    title-prefix: "[daily-compiler-quality] "
  noop:

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix daily compiler quality check no safe outputs issue Require explicit safe output completion in daily compiler quality workflow Jun 27, 2026
Copilot AI requested a review from pelikhan June 27, 2026 04:57
@pelikhan pelikhan marked this pull request as ready for review June 27, 2026 05:15
Copilot AI review requested due to automatic review settings June 27, 2026 05:15
@pelikhan pelikhan merged commit 146abd7 into main Jun 27, 2026
@pelikhan pelikhan deleted the copilot/debug-daily-compiler-check branch June 27, 2026 05:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the daily compiler quality workflow’s safe-output contract so runs end with an explicit, recordable outcome (either publishing a discussion report or explicitly doing nothing via noop), and adds a regression test to keep the contract stable across compilation.

Changes:

  • Adds a noop entry to the workflow’s safe-outputs block to explicitly support “no action” outcomes.
  • Strengthens the workflow prompt to require finishing with either create_discussion or noop (never plain text only).
  • Adds a focused Go test to assert the source workflow declares noop and the compiled lockfile still wires safe-output tooling as expected.
Show a summary per file
File Description
pkg/workflow/daily_compiler_quality_workflow_test.go Adds a regression test that validates the workflow source + compiled lockfile include the expected safe-output contract.
.github/workflows/daily-compiler-quality.md Declares noop as an allowed safe-output and adds an explicit end-of-run guardrail in the prompt.
.github/workflows/daily-compiler-quality.lock.yml Updates the compiled workflow lock output to reflect the updated workflow contract.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Low

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.81.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants