[skill-activity] fix: correct agent instructions editing guidance in step 12#192
Merged
Merged
Conversation
Step 12 incorrectly told learners to find and edit a 'prompt:' key in the YAML frontmatter. In gh-aw workflows, agent instructions live in the Markdown body below the closing '---' fence — the frontmatter only holds machine-readable configuration. Also fix misleading error-recovery advice: the daily-status workflow uses safe-outputs for write access, not 'issues: write' in permissions. Adding 'issues: write' is unnecessary and violates the least-privilege principle the workshop teaches. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was improved
Step 12 (Test and Improve Your Workflow) contained two instructional errors that would confuse learners at a critical point in the workshop.
Error 1 — Incorrect
prompt:key reference:The step told learners to "find the
prompt:block in the frontmatter" and showed aprompt: |YAML key as the place to make changes. In reality,gh-awworkflows have noprompt:frontmatter key — the agent instructions live in the Markdown body below the closing---fence. A learner following the original instructions would look for a key that doesn't exist.Error 2 — Wrong permissions advice for failures:
The error-recovery section said to add
issues: writeto fix missing-permissions failures. Thedaily-statusworkflow usessafe-outputsfor all write access —issues: writeis not needed, and adding it contradicts the least-privilege principle the workshop explicitly teaches in step 11.Learner pain point addressed
Both errors appear in the iteration loop (step 4 of step 12) — the exact moment learners are supposed to make their first successful improvement. Hitting a dead end here (can't find
prompt:, wrong fix for failures) creates frustration that undermines confidence just before the scheduling step.Why it helps workshop flow
Fixing these errors keeps the "write → run → improve" feedback loop working cleanly. Learners can now successfully edit the Markdown body, re-run, and see the effect of their change — which is the core learning outcome of this step.