Whitelist various inline semantic/formatting tags#306
Merged
gjtorikian merged 1 commit intoJan 4, 2019
Conversation
Mostly I want <abbr>, but the rest of these should also be whitelisted. What goes in LIMITED.elements seems to be a bit subjective, but I think that <mark> and <abbr> at least are reasonably justified. <dfn> is fairly obscure, and <small>, <bdo>, <cite>, <span>, <time> and <wbr> a bit different from the rest and probably not justified, so I left them out. In the absence of styling, <span> is quite useless, but <div>’s there already, and people have asked for <span> (gjtorikian#183), so I figured, why not? Fixes gjtorikian#183.
Owner
|
Seems reasonable, thank you for your contribution. |
Owner
|
This is out now as 2.9.2. |
|
Spans are not entirely useless without styling. They can be given an id an used as anchors. This is useful e.g. in Pandoc which has a native span syntax. Besides |
Contributor
Author
|
True, though I think normally you want to put the ID on something else (typically a heading). I had forgotten about that use case. |
chris-morgan
deleted the
whitelist-abbr-and-various-other-inline-semantic-elements
branch
January 4, 2019 22:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly I want
<abbr>, but the rest of these should also be whitelisted.What goes in LIMITED.elements seems to be a bit subjective, but I think that
<mark>and<abbr>at least are reasonably justified.<dfn>is fairly obscure, and<small>,<bdo>,<cite>,<span>,<time>and<wbr>a bit different from the rest and probably not justified, so I left them out.In the absence of styling,
<span>is quite useless, but<div>’s there already, and people have asked for<span>(#183), so I figured, why not?Fixes #183.