Skip to content

Allow role attributes in html tags#332

Merged
gjtorikian merged 1 commit into
gjtorikian:masterfrom
eric-wieser:patch-1
May 28, 2020
Merged

Allow role attributes in html tags#332
gjtorikian merged 1 commit into
gjtorikian:masterfrom
eric-wieser:patch-1

Conversation

@eric-wieser

Copy link
Copy Markdown
Contributor

@gjtorikian

Copy link
Copy Markdown
Owner

Yeah, that makes sense. Thanks!

@gjtorikian
gjtorikian merged commit 565eaee into gjtorikian:master May 28, 2020
@gjtorikian

Copy link
Copy Markdown
Owner

This is out now as 2.13.0.

@eric-wieser

Copy link
Copy Markdown
Contributor Author

Out of curiosity, do you have a feel for the length of the pipeline between your release and GitHub using it for readme contents?

@gjtorikian

Copy link
Copy Markdown
Owner

GitHub doesn't use this gem.

@eric-wieser

eric-wieser commented May 28, 2020

Copy link
Copy Markdown
Contributor Author

Looks like I was led here by mistake! github/markup#245 (comment) is clearly out of date.

Oh well, hope someone benefits from this change.

@gjtorikian

Copy link
Copy Markdown
Owner

Ah, yeah, sorry! They move to an internal fork, so perhaps try contacting their Support team?

FWIW the README mentions GitHub's not using this: https://github.com/jch/html-pipeline#htmlpipeline-

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants