fix(contrib/drivers/mysql): use unreachable port for nodeInvalid test config#4726
Merged
Merged
Conversation
… config The nodeInvalid config was using port 3307, which may collide with a running MariaDB instance in CI. Change it to port 3316 (default+10) so the connection is guaranteed to fail as intended.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MySQL driver unit test setup to make the nodeInvalid configuration reliably fail to connect in CI, avoiding accidental connections to a running MariaDB/MySQL instance.
Changes:
- Change
nodeInvalidDSN port from3307to3316to reduce collision risk with services running on common ports.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gqcn
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ref #4689