feat: implement runtime schema validation for AgentTool#456
Closed
AmaadMartin wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements runtime input and output schema validation for agents wrapped as tools using
AgentTool.Key Changes
LlmAgentto store original schemas (inputSchemaandoutputSchemaasLlmAgentSchemawhich can be Zod or GenAI Schema) directly, rather than eagerly converting them to GenAI Schema in the constructor. Conversion is now performed on-demand when needed:AgentTool._getDeclaration()for tool declaration.BasicLlmRequestProcessorfor passing to model config.AgentTool.runAsyncvalidates the input arguments against the agent'sinputSchema(if it's a Zod object). Throws an error on validation failure.AgentTool.runAsyncparses the output as JSON and validates it against the agent'soutputSchema(if it's a Zod object). Throws an error on validation failure.zodObjectToSchemahelper to accept and returnSchemaas-is if it is not a Zod object, simplifying call sites.Testing
core/test/tools/agent_tool_test.tscovering:tests/integration/tools/agent_tool_test.tsto verify: