Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Correct exit code if number of errors % 256 == 0 #6

Merged
merged 1 commit into from
Feb 14, 2015

Conversation

lamby
Copy link
Contributor

@lamby lamby commented Feb 14, 2015

For example, we had 256 errors (etc.) our process will exit with a
successful error code which is incorrect and/or misleading.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@lamby
Copy link
Contributor Author

lamby commented Feb 14, 2015

Signed.

@googlebot
Copy link

CLAs look good, thanks!

@aliafshar
Copy link
Contributor

Hi, thanks for this. I prefer explicly setting the error to 1 or 0

For example, we had 256 errors (etc.) our process will exit with a
successful error code which is incorrect and/or misleading.
@lamby lamby force-pushed the correct-sys-exit-usage branch from 891eebe to 7325b8f Compare February 14, 2015 15:12
@lamby
Copy link
Contributor Author

lamby commented Feb 14, 2015

Hi, thanks for this. I prefer explicly setting the error to 1 or 0

Fair. Updated.

@aliafshar
Copy link
Contributor

Thanks 👍

aliafshar added a commit that referenced this pull request Feb 14, 2015
Correct exit code if number of errors % 256 == 0
@aliafshar aliafshar merged commit 8aa2bb6 into google:master Feb 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants