Skip to content

Fix CMake build in test subdirectories - #3845

Merged
Mizux merged 1 commit into
google:mainfrom
Boulevard:fix-test-subdirectory-builds
Jul 5, 2023
Merged

Mizux merged 1 commit into
google:mainfrom
Boulevard:fix-test-subdirectory-builds

Conversation

@lnikkila

@lnikkila lnikkila commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Due to the regexes, ortools_pdlp fails to build if any of its parent directories starts with test or gtest:

CMake Error at test/ortools-src/ortools/pdlp/CMakeLists.txt:27 (add_library):
  No SOURCES given to target: ortools_pdlp

Due to the regexes, ortools_pdlp fails to build if any of its parent
directories starts with `test` or `gtest`:

    CMake Error at test/ortools-src/ortools/pdlp/CMakeLists.txt:27 (add_library):
      No SOURCES given to target: ortools_pdlp
@lnikkila
lnikkila force-pushed the fix-test-subdirectory-builds branch from 730157f to 39edf98 Compare July 4, 2023 20:00

@Mizux Mizux left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thx for the fix !

@Mizux
Mizux merged commit ab9b9a0 into google:main Jul 5, 2023
@Mizux Mizux self-assigned this Jul 5, 2023
@Mizux Mizux added Bug Build: CMake CMake based build issue labels Jul 5, 2023
@Mizux Mizux added this to the v9.7 milestone Jul 5, 2023
@lnikkila
lnikkila deleted the fix-test-subdirectory-builds branch July 5, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Build: CMake CMake based build issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants