Avoid CMake config file case issues. #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://cmake.org/cmake/help/latest/command/find_package.html says that the config file can take two forms, <PackageName>Config.cmake or <lower-case-package-name>-config.cmake. Right now we use the -config form but don't transform the name to lower case. Experimentally CMake uses the C locale for this, but the docs don't take a stance (although it appears that anything outside `[A-Za-z0-9_.:+-]+` isn't valid in a target name anyway), so just avoid the problem altogether than use the untransformed name. No test added because until we actually work a full end-to-end test that actually runs CMake into our tests there isn't any useful test to write here. Fixes google#98
enh-google
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cmake.org/cmake/help/latest/command/find_package.html says
that the config file can take two forms, Config.cmake or
-config.cmake. Right now we use the -config
form but don't transform the name to lower case.
Experimentally CMake uses the C locale for this, but the docs don't
take a stance (although it appears that anything outside
[A-Za-z0-9_.:+-]+isn't valid in a target name anyway), so justavoid the problem altogether than use the untransformed name.
No test added because until we actually work a full end-to-end test
that actually runs CMake into our tests there isn't any useful test to
write here.
Fixes #98