[Firestore] WriteBatch doesn't return instance so you cannot chain. #6548

Activity

1. crwilcox

   added

   api: firestoreIssues related to the Firestore API.Issues related to the Firestore API.

   triaged for GA

   on Nov 16, 2018
2. tseaver commented on Nov 16, 2018

   

   tseaver

   on Nov 16, 2018

   Contributor

   More actions

   We pretty much never do chaining in Python libs.
3. JustinBeckwith

   added

   triage meI really want to be triaged.I really want to be triaged.

   on Nov 17, 2018
4. tseaver

   added

   type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.

   on Nov 19, 2018
5. JustinBeckwith

   removed

   triage meI really want to be triaged.I really want to be triaged.

   on Nov 19, 2018
6. tseaver commented on Nov 26, 2018

   

   tseaver

   on Nov 26, 2018

   Contributor

   More actions

   I would suggest that the "Pythonic" way to provide multiple operations would be to make WriteBatch a context manager, invoking commit from within its __exit__. E.g.:

   with client.batch() as batch:
       batch.create(client.document('documents', 'foo'), {...})
       batch.set(client.document('documents, 'bar'), {...}, merge=True)
       batch.delete(client.document('documents, 'baz'))

   I'm surprised that it doesn't already operate this way.
7. tseaver

   closed this as completedin #6912on Dec 17, 2018
8. tseaver

   added a commit that references this issue on Dec 17, 2018

   Enable use of 'WriteBatch' as a context manager. (#6912)

   ...

   This issue will close once commit 54e87e1 is merged into the 'main' branch.

   54e87e1
9. JustinBeckwith

   assigned

   tseaver

   on Feb 1, 2021
10. parthea

    added a commit that references this issue on Nov 24, 2025

    Enable use of 'WriteBatch' as a context manager. (#6912)

    ...

    This issue will close once commit acad4a0 is merged into the 'main' branch.

    acad4a0