Skip to content

Firestore: preserve timestamp nanos in document data - #6920

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:6547-firestore-preserve_timestamp_nanos_in_document_data
Dec 17, 2018
Merged

tseaver merged 1 commit into
googleapis:masterfrom
tseaver:6547-firestore-preserve_timestamp_nanos_in_document_data

Conversation

@tseaver

@tseaver tseaver commented Dec 13, 2018

Copy link
Copy Markdown
Contributor

Uses #6919 as a base: please review only the last commit here until rebased after merging that PR.

Closes #6547.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Dec 13, 2018
@tseaver
tseaver requested review from crwilcox and mcdonc December 13, 2018 18:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 13, 2018
@tseaver

tseaver commented Dec 13, 2018

Copy link
Copy Markdown
Contributor Author

The automl failure is a bug in Kokoro, or our setup for it.

error pulling image configuration: Get https://gcr.io/v2/cloud-devrel-kokoro-resources/python-multi/blobs/sha256:bfcdfded6f494ed45ee36a4f28908e3a4b69b9afee63bf0e848bd763cc7bce38: dial tcp 74.125.20.82:443: i/o timeout
Failed to pull docker image, attempt 0 out of 3.
Failed to pull docker image, attempt 1 out of 3.
Failed to pull docker image, attempt 2 out of 3.
Traceback (most recent call last):
  File "/tmpfs/src/gfile/trampoline_v1.py", line 132, in <module>
    main()
  File "/tmpfs/src/gfile/trampoline_v1.py", line 126, in main
    pull_docker_image(image)
  File "/tmpfs/src/gfile/trampoline_v1.py", line 66, in pull_docker_image
    raise RuntimeError("Failed to pull image {}.".format(image))
RuntimeError: Failed to pull image gcr.io/cloud-devrel-kokoro-resources/python-multi.

@crwilcox Failed systests are all due to quota issues in the watch tests.

@mcdonc mcdonc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver
tseaver merged commit 274c3a2 into googleapis:master Dec 17, 2018
@tseaver
tseaver deleted the 6547-firestore-preserve_timestamp_nanos_in_document_data branch March 4, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants