Repository navigation
Prevent requests from hanging on SSL handshake issue by adding a max t.o. - #8207
Merged
Merged
Conversation
…timeout of 5 minutes
busunkim96
approved these changes
Jun 3, 2019
tseaver
self-requested a review
June 4, 2019 17:08
tseaver
suggested changes
Jun 4, 2019
tseaver
left a comment
Contributor
There was a problem hiding this comment.
I've checked the google-auth bits, and they are fine (I was worried about seconds vs. milliseconds, but the library uses seconds).
tseaver
approved these changes
Jun 5, 2019
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…t.o. (#8207) * Prevent requests from hanging on SSL handshake issue by adding a max timeout of 5 minutes * rename and reuse constant * use named arg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auth library defaults to timeout of None, effectively having no timeout. This adds a default timeout of 5 minutes for all users of the core._http implementation
b/132819217