Repository navigation
feat(firestore): Support REST transport - #20446
Merged
Merged
Conversation
dazuma
marked this pull request as draft
February 17, 2023 02:07
dazuma
force-pushed
the
pr/firestore-rest
branch
2 times, most recently
from
February 17, 2023 03:15
eec9c07 to
ec6b059
Compare
dazuma
marked this pull request as ready for review
February 17, 2023 03:21
bajajneha27
approved these changes
Feb 17, 2023
Contributor
Author
|
I realize this will also need to update the dependency on google-cloud-firestore-v1 to whatever release includes #20444. |
Contributor
|
Dependency on google-cloud-firestore-v1 resolved. Should be mergable now. |
dazuma
force-pushed
the
pr/firestore-rest
branch
from
February 17, 2023 18:08
ec6b059 to
4d20f97
Compare
Contributor
Author
|
@kolea2 FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal here is actually to get integration tests running for REST transport. We picked Firestore because there are streaming calls. But this PR effectively adds REST support to the handwritten layer.