Skip to content

fix: populate table id for materialized view #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

fix: populate table id for materialized view #2610

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c56423
fix: populate table id for materialized view
mutianf Jun 20, 2025
2088ccd
Merge branch 'main' into mat-view
mutianf Jun 20, 2025
144cdb7
Merge branch 'main' into mat-view
mutianf Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: populate table id for materialized view
  • Loading branch information
@mutianf
mutianf committed Jun 20, 2025
commit 9c564233f7a26fbc3215388bbfbdd8e7306dc10b
7 changes: 7 additions & 0 deletions google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import com.google.bigtable.v2.AuthorizedViewName;
import com.google.bigtable.v2.CheckAndMutateRowRequest;
import com.google.bigtable.v2.GenerateInitialChangeStreamPartitionsRequest;
import com.google.bigtable.v2.MaterializedViewName;
import com.google.bigtable.v2.MutateRowRequest;
import com.google.bigtable.v2.MutateRowsRequest;
import com.google.bigtable.v2.ReadChangeStreamRequest;
Expand Down Expand Up @@ -121,9 +122,11 @@ static TagValue extractStatusFromFuture(Future<?> future) {
static String extractTableId(Object request) {
String tableName = null;
String authorizedViewName = null;
String materializedViewName = null;
if (request instanceof ReadRowsRequest) {
tableName = ((ReadRowsRequest) request).getTableName();
authorizedViewName = ((ReadRowsRequest) request).getAuthorizedViewName();
materializedViewName = ((ReadRowsRequest) request).getMaterializedViewName();
} else if (request instanceof MutateRowsRequest) {
tableName = ((MutateRowsRequest) request).getTableName();
authorizedViewName = ((MutateRowsRequest) request).getAuthorizedViewName();
Expand All @@ -133,6 +136,7 @@ static String extractTableId(Object request) {
} else if (request instanceof SampleRowKeysRequest) {
tableName = ((SampleRowKeysRequest) request).getTableName();
authorizedViewName = ((SampleRowKeysRequest) request).getAuthorizedViewName();
materializedViewName = ((SampleRowKeysRequest) request).getMaterializedViewName();
} else if (request instanceof CheckAndMutateRowRequest) {
tableName = ((CheckAndMutateRowRequest) request).getTableName();
authorizedViewName = ((CheckAndMutateRowRequest) request).getAuthorizedViewName();
Expand All @@ -150,6 +154,9 @@ static String extractTableId(Object request) {
if (authorizedViewName != null && !authorizedViewName.isEmpty()) {
return AuthorizedViewName.parse(authorizedViewName).getTable();
}
if (materializedViewName != null && !materializedViewName.isEmpty()) {
return MaterializedViewName.parse(materializedViewName).getMaterializedView();
}
return "<unspecified>";
}

Expand Down
1 change: 1 addition & 0 deletions ...table/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableMaterializedViewIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ public static void createInstance() throws IOException {
Instance instance =
client.createInstance(
CreateInstanceRequest.of(new PrefixGenerator().newPrefix())
.setDisplayName("BigtableMaterializedViewIT")
.addCluster("my-cluster", "us-east1-c", 3, StorageType.SSD));
instanceId = instance.getId();
tableAdminClient =
Expand Down