This repository was archived by the owner on Aug 30, 2026. It is now read-only.
Repository navigation
fix: Fix typehint on AsyncDocumentReference.get() - #649
Merged
Merged
Conversation
Contributor
|
Thanks for the PR! This will fix issue #627 There were lint errors due to unused imports. Can you please address those? |
Mariatta
suggested changes
Nov 10, 2022
Mariatta
left a comment
Contributor
There was a problem hiding this comment.
Remove unused imports so lint will pass.
Mariatta
approved these changes
Nov 10, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither of the return statements is a call to an async function.
Fixes #627