Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

fix: Fix typehint on AsyncDocumentReference.get() #649

Merged
Mariatta merged 4 commits into from
Nov 10, 2022
Merged

fix: Fix typehint on AsyncDocumentReference.get() #649

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dac5b65
fix: AsyncDocumentReference.get() only returns 1 level of coroutine.
jyasskin Oct 7, 2022
9b68712
Merge branch 'main' into patch-1
Mariatta Nov 10, 2022
9ccd2b6
Merge branch 'main' into patch-1
Mariatta Nov 10, 2022
4fa9106
Remove no-longer-used imports.
jyasskin Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/firestore_v1/async_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from google.cloud.firestore_v1 import _helpers
from google.cloud.firestore_v1.types import write
from google.protobuf.timestamp_pb2 import Timestamp
from typing import Any, AsyncGenerator, Coroutine, Iterable, Union
from typing import AsyncGenerator, Iterable


logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -329,7 +329,7 @@ async def get(
transaction=None,
retry: retries.Retry = gapic_v1.method.DEFAULT,
timeout: float = None,
) -> Union[DocumentSnapshot, Coroutine[Any, Any, DocumentSnapshot]]:
) -> DocumentSnapshot:
"""Retrieve a snapshot of the current document.

See :meth:`~google.cloud.firestore_v1.base_client.BaseClient.field_path` for
Expand Down