This repository was archived by the owner on Aug 30, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 30, 2026. It is now read-only.
transactions that aren't retried don't rollback #765
Description
in Transaction.call, rollback is called when retries are exhausted, or when pre-commit fails, but other exceptions cause an immediate raise, without any rollback.
To fix this, the entire __call__ function should be wrapped in a try...except block, that causes a rollback before any exceptions are raised out of the transaction
Activity
kolea2 commentedon Jan 10, 2024
It looks like this was fixed in #767, closing. @daniel-sanche please reopen if needed. Thanks!