Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

docs(firestore): on_snapshot document changes - #27

Closed
HemangChothani wants to merge 7 commits into
googleapis:masterfrom
MaxxleLLC:firestore_issue_26
Closed

HemangChothani wants to merge 7 commits into
googleapis:masterfrom
MaxxleLLC:firestore_issue_26

Conversation

@HemangChothani

Copy link
Copy Markdown
Contributor

Fixes #26

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2020
@HemangChothani HemangChothani changed the title Firestore issue 26 docs(firestore): on_snapshot document changes Mar 17, 2020
@BenWhitehead
BenWhitehead requested review from tseaver and removed request for BenWhitehead March 17, 2020 18:59
@BenWhitehead

Copy link
Copy Markdown
Contributor

@crwilcox or @tseaver Can either of you review this? I'm not familiar with pythons type annotations.

@crwilcox

Copy link
Copy Markdown
Contributor

@HemangChothani can you update this branch?

Also, not sure why this change is being made? It seems to edit actual types of functions, not just the annotations.

@crwilcox

Copy link
Copy Markdown
Contributor

#79 opened with me merging master. Thanks!

@crwilcox crwilcox closed this Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inconsistent type annotations for Document.on_snapshot

4 participants