fix(java): relax license header replacement regex and use current year #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2020
Contributor
SurferJeffAtGoogle
left a comment
There was a problem hiding this comment.
This works against the principle of reproducible builds. Building with the exact same tools and the same source files will yield different output if the date changes.
SurferJeffAtGoogle
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the fixed license headers to use the current year. Generated sources from protoc and grpc do not include license headers so synthtool currently injects them as part of the pipeline. It also fixes the formatting of the header from the gapic-generator for resource name classes.
Added link to issue filed on gapic-generator for the header formatting: googleapis/gapic-generator#3074