Skip to content

[WIP] Fix for #383 "Python tests does not count over make cover" #95

Open

Description

@alanjds

google#389 opened on Dec 12, 2017 by alanjds

Activity

  1. alanjds commented on Oct 6, 2018

    @alanjds
    Author

    Comment by alanjds
    Wednesday Dec 13, 2017 at 19:48 GMT


    build/bin/gentest:99: Bad indentation. Found 4 spaces, expected 2 (bad-indentation)

    Are we using 2-spaces indent on Python code?

  2. alanjds commented on Oct 6, 2018

    @alanjds
    Author

    Comment by alanjds
    Wednesday Jan 10, 2018 at 18:45 GMT


    Hi, @BTaskaya.

    Can you please take a look on google#383 (comment) if having some time? I am a bit tied for the next weeks...

    Thanks for the review.

  3. alanjds commented on Oct 6, 2018

    @alanjds
    Author

    Comment by ghost
    Wednesday Jan 10, 2018 at 20:04 GMT


    Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    imported PRPull Request imported from google/grumpy

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions