Skip to content

Adds new question for the javascript interview #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

pixxstudios
Copy link

Updates the coding-question.md file to add Javascript coding question.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • [x ] New Question

Checklist:

  • [ x] My content follows the style guidelines of this project
  • [ x] I have performed a self-review of my own content

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

Copy link
Member

@darcyclarke darcyclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixxstudios appreciate the contribution. Just wondering how we could potentially change this question a bit to help better articulate the concept you're asking of the interview (ie. prototypal inheritance). Maybe we could change this example/snippet to not include an error/bug out of the box. Maybe something like this.


Question: Can you update the example code below to add a new drive() function to the Car object? This function should simply console.log some value when it's executed.

function Car() {}
// your code here...
const honda = new Car();
honda.drive(); // this should console.log some value 

@pixxstudios
Copy link
Author

Hi Darcy,

Thanks for the feedback. I have updated the description and the question format based on your suggestion and updated the pull request.

Thanks.

@stale
Copy link

stale bot commented Nov 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 14, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants