⚡ perf(lang): optimize lexer keyword/identifier parsing#1752
Merged
Conversation
Merging this PR will improve performance by 15.44%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | eval_array_chained_operations |
9.8 ms | 8.7 ms | +12.17% |
| ⚡ | eval_array_filter |
10.4 ms | 9.3 ms | +11.25% |
| ⚡ | eval_nested_object_access |
7.4 ms | 6.3 ms | +17.37% |
| ⚡ | eval_nodes |
7 ms | 5.9 ms | +17.83% |
| ⚡ | eval_array_fold |
8 ms | 7 ms | +15.23% |
| ⚡ | eval_string_interpolation |
60.7 µs | 55 µs | +10.31% |
| ⚡ | eval_variable_assignment_chain |
876.8 µs | 749.7 µs | +16.95% |
| ⚡ | eval_object_field_access |
7.8 ms | 6.7 ms | +16.41% |
| ⚡ | eval_array_map |
8.6 ms | 7.6 ms | +14.13% |
| ⚡ | eval_yaml_parse |
8.1 ms | 6.8 ms | +18.68% |
| ⚡ | eval_pipeline_with_conditionals |
7.6 ms | 6.5 ms | +16.34% |
| ⚡ | eval_csv_parse |
8 ms | 6.7 ms | +19.06% |
| ⚡ | parse_fibonacci |
188.9 µs | 171 µs | +10.45% |
| ⚡ | eval_foreach |
7.4 ms | 6.3 ms | +16.68% |
| ⚡ | eval_qualified_access_to_csv_module |
8 ms | 6.8 ms | +18.82% |
| ⚡ | eval_if_else_branching |
8.8 ms | 7.7 ms | +13.83% |
| ⚡ | eval_string_equality |
7.4 ms | 6.2 ms | +18.4% |
| ⚡ | eval_json_parse |
7.6 ms | 6.4 ms | +18.42% |
| ⚡ | eval_macro_expansion_nested |
111.4 µs | 98.6 µs | +12.9% |
| ⚡ | eval_long_pipeline |
8.4 ms | 7.3 ms | +14.21% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/lexer-ident-keyword-optimization (f5575f4) with main (3bef7c2)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving mq-lang lexer performance by simplifying keyword handling and reducing allocations during comment skipping.
Changes:
- Replaced many per-keyword parsers with a consolidated
ident_or_keywordmatcher. - Added
skip_commentto skip# ...comments without allocating comment text in the whitespace-skip path. - Updated token parsing order to rely on
ident_or_keywordfor keyword recognition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.