Skip to content

🐛 fix(table): flush current_row before finalizing table on block boundary#1840

Merged
harehare merged 1 commit into
mainfrom
fix/table-last-row-dropped
Jun 8, 2026
Merged

🐛 fix(table): flush current_row before finalizing table on block boundary#1840
harehare merged 1 commit into
mainfrom
fix/table-last-row-dropped

Conversation

@harehare

@harehare harehare commented Jun 8, 2026

Copy link
Copy Markdown
Owner

When tables() encountered a non-table node (paragraph, heading, thematic break) it flushed current_rows to the result without first committing the in-progress current_row buffer. This silently dropped the last data row of any table followed by a non-table block.

#1839

…dary

When `tables()` encountered a non-table node (paragraph, heading,
thematic break) it flushed `current_rows` to the result without first
committing the in-progress `current_row` buffer. This silently dropped
the last data row of any table followed by a non-table block.
@codspeed-hq

codspeed-hq Bot commented Jun 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 29 untouched benchmarks


Comparing fix/table-last-row-dropped (054951e) with main (f2d9e05)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (3856817) during the generation of this report, so f2d9e05 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@harehare harehare merged commit 10353a3 into main Jun 8, 2026
10 checks passed
@harehare harehare deleted the fix/table-last-row-dropped branch June 8, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant