[#87] Fix completion via ghcide's getCompletionsLSP

[korayal]

fixes #71 and #87

This fix requires the ghcide's Development.IDE.Plugin.Completions module to expose getCompletionsLSP

[Avi-D-coder]

@korayal It looks like the build is failing

[korayal]

I'm aware, as I stated in the PR, it requires a change in the ghcide library.

…

On Tue, May 12, 2020, 02:35 Avi Dessauer ***@***.***> wrote: @korayal <https://github.com/korayal> It looks like the build is failing — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#107 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACMTSOA5OD74R26DDZASKLRRCDUTANCNFSM4M6KTETQ> .

[ndmitchell]

@korayal - is there a corresponding upstream commit to expose it from ghcide?

[korayal]

@ndmitchell I haven't pushed that change to anywhere because hls is using @alanz 's fork. So I thought it would be easier to make the change there directly. But here you go:

korayal/ghcide@f594fd1

[Avi-D-coder]

I can confirm this fixed my issue, @korayal can you send a PR to @alanz's ghcide fork exposing getCompletionsLSP.

[korayal]

@Avi-D-coder done:
alanz/ghcide#3

[fendor]

@korayal could you rather open it against https://github.com/mpickering/ghcide ?
That is the main-line fork that @alanz's pr is based on, we do not want to diverge from it.

[korayal]

@fendor sure, initially I was a bit confused where to make this PR, so I thought allowing the project maintainers to make the change wherever it's easiest. But, anyways, here you go: mpickering/ghcide#36

[fendor]

sure, initially I was a bit confused where to make this PR

I feel you, it is not as transparent/hard to find in github.
Thank you for your PR!

[korayal]

@fendor @alanz since the necessary changes are merged, I think the next step to wrap this PR up is to merge the latest ghcide into the fork.