Bump haskell-lsp to 0.23#1146
Merged
Merged
Conversation
pepeiborra
approved these changes
Jan 2, 2021
pepeiborra
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks!
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Jan 9, 2021
* Bump haskell-lsp to 0.23 * Update extra-deps Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: Junyoung Clare Jang <jjc9310@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before migrating to lsp-1.0, which will be done by haskell/ghcide#857, I think version 0.23.0 should be allowed, so that distribution packages like https://archlinux.org/packages/community/x86_64/haskell-lsp-types/ or https://hydra.nixos.org/job/nixpkgs/trunk/haskellPackages.haskell-lsp-types_0_23_0_0.x86_64-linux could be picked by cabal, instead of constructing a build plan which includes the old version lsp, preventing from using binary caches.