Add emacs/doom-emacs integration sub-section#115
Merged
Conversation
fendor
requested changes
May 17, 2020
fendor
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the addition!
Some nitpicks
|
|
||
| Note to editor integrators: there is now a haskell-language-server-wrapper executable, which is installed alongside the haskell-language-server executable. When this is invoked in the project root directory, it attempts to work out the GHC version used in the project, and then launch the matching hie executable. | ||
|
|
||
| All of the editor integrations assume that you have already installed HLS (see above) and that stack put the hls binary in your path (usually ~/.local/bin on linux and macOS). |
Collaborator
There was a problem hiding this comment.
Also, we ought to be build tool agnostic, since we support stack and cabal. Either mention both or be less specific, such as:
that the installation script put the haskell-language-server binary in your path ...
|
|
||
| ``` emacs-lisp | ||
| (after! lsp-haskell | ||
| (setq lsp-haskell-process-path-hie "haskell-language-server-wrapper") |
Member
fendor
requested changes
May 18, 2020
fendor
left a comment
Collaborator
There was a problem hiding this comment.
Last nitpick, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add subsection for emacs/doom-emacs integration