Skip to content

Prepare 0.8.0 (versions)#1153

Merged
jneira merged 10 commits into
haskell:masterfrom
jneira:prepare-0.8.0-2
Jan 4, 2021
Merged

Prepare 0.8.0 (versions)#1153
jneira merged 10 commits into
haskell:masterfrom
jneira:prepare-0.8.0-2

Conversation

@jneira

@jneira jneira commented Jan 3, 2021

Copy link
Copy Markdown
Member
  • This pr include version bumps for all components (hls itself, hls-plugin-api and ghcide)
  • A hackage index update
  • Also a fix to macos builds
  • And a mention to lib versions and ghcide-0.6.0.2 changelog

Follow up of #1149

@jneira
jneira requested review from Ailrun, alanz and pepeiborra January 3, 2021 15:39
@jneira jneira changed the title Prepare 0.8.0.2 (versions) Prepare 0.8.0 (versions) Jan 3, 2021
Comment thread ChangeLog.md Outdated
@pepeiborra

Copy link
Copy Markdown
Collaborator

Thanks. Are you planning to update the ghcide changelog as well?

@alanz alanz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Pepe Iborra <pepeiborra@me.com>
@jneira

jneira commented Jan 3, 2021

Copy link
Copy Markdown
Member Author

Thanks. Are you planning to update the ghcide changelog as well?

We weren't update the changelog of each subcomponent until now and the changelog contains pr's affecting one o more of them at the same time. But maybe we could start to do it, at least for ghcide.

should we keep those pr's in the main changelog and in ghcide one or only in the latter?

@jneira

jneira commented Jan 3, 2021

Copy link
Copy Markdown
Member Author

@pepeiborra i've added some entries in the ghcide changelog, keeping the main hls one instact. I've taken the list of your comment in the previous pr, removing the existent ones.

@pepeiborra

Copy link
Copy Markdown
Collaborator

Thanks. Are you planning to update the ghcide changelog as well?

We weren't update the changelog of each subcomponent until now and the changelog contains pr's affecting one o more of them at the same time. But maybe we could start to do it, at least for ghcide.

I must be missing something. In #1149 you said that the ghcide changes should go in the ghcide changelog:

@pepeiborra hi, thanks for the suggestion. However, some of those pr's are already included in the ghcide Changelog or in the actual list of merged pr's. The unique i miss from both lists is haskell/ghcide#952, that was merged before ghcide-0.6.0.2 but no listed in the changelog for some reason. It seems its place would be the ghcide Changelog.
#1149 (comment)

That's why I am asking if you are planning to update the ghcide changelog before releasing it.

should we keep those pr's in the main changelog and in ghcide one or only in the latter?

I don't have an opinion. Probably a link is enough

@jneira

jneira commented Jan 3, 2021

Copy link
Copy Markdown
Member Author

Mmm, i see, my intent was to add the missing info (#952) in the last version included in the ghcide changelog (0.6.0.2). With It seems its place would be the ghcide Changelog. i was referring only to that pr.

... and keep the rest of ghcide related pr's, merged after it inclusion in this repo, in the main hls changelog (as they were already included there at that point). But continuing the ghcide changelog seems sensible to me too.

@Ailrun Ailrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneira
jneira merged commit eb58f13 into haskell:master Jan 4, 2021
@jneira
jneira deleted the prepare-0.8.0-2 branch January 15, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants