Test only last ghc minor version and fix windows cache by jneira · Pull Request #1173 · haskell/haskell-language-server

jneira · 2021-01-08T12:51:11Z

With this configuration, even including macOS builds, the full test workflow takes 47 minutes (https://github.com/jneira/haskell-language-server/actions/runs/471611988). Now it takes 1h 27m 24s (https://github.com/haskell/haskell-language-server/actions/runs/471363372)
- Testing macOs builds takes only 58 min: https://github.com/jneira/haskell-language-server/actions/runs/471344446 so maybe we could add them
I've dropped optional restore keys cause the builds were hitting other incompatible cache, so it was rebuilding everything in every run cause the final store was not being saved. 😟

jneira · 2021-01-08T19:22:37Z

In this repo the test workflow takes 46 min: https://github.com/haskell/haskell-language-server/actions/runs/472245636

pepeiborra · 2021-01-08T20:31:44Z


      - name: Test func-test suite
-        shell: bash
+        if: ${{ !matrix.ghc-lib && matrix.test }}


Suggested change

if: ${{ !matrix.ghc-lib && matrix.test }}

if: ${{ matrix.test }}

pepeiborra · 2021-01-08T20:31:52Z


      - name: Test wrapper-test suite
-        shell: bash
+        if: ${{ !matrix.ghc-lib && matrix.test }}


Suggested change

if: ${{ !matrix.ghc-lib && matrix.test }}

if: ${{ matrix.test }}

pepeiborra

Thanks!

Ailrun

LGTM

Ailrun · 2021-01-10T06:15:41Z

It looks like we should update .github/mergify.yml too, as the file now contains some outdated ci test entries.

Ailrun · 2021-01-10T22:33:37Z

And could you update the GitHub setting for the required checks (I don't have the permission)? It looks like the removed checks remain required.

jneira · 2021-01-11T06:28:39Z

It seems the mergify config from master is not replaced by this one, weird...
I think the right way is doing another pull request only to remove them and rebase this one.

The mergify config is not completely updated and is required to remove them to unblock haskell#1173

Remove runs dropped by #1173

jneira · 2021-01-11T09:07:54Z

@Ailrun is right, we had to update checks in github settings (in addition to mergify)
In fact we should update there all new checks added with this pr

jneira · 2021-01-11T10:39:29Z

I've changed the required checks in github settings to match the established ones with this pr.
@Ailrun you should have admin rights to see and change them now, please take a look to confirm they are correct 😺

Ailrun · 2021-01-11T16:23:08Z

Checked. The updated setting looks good to me. Thank you for the CI update!

The mergify config is not completely updated and is required to remove them to unblock haskell#1173

jneira requested a review from pepeiborra January 8, 2021 12:51

jneira force-pushed the fix-win-cache branch from 00e99cd to e53ebf1 Compare January 8, 2021 16:36

jneira requested a review from Ailrun January 8, 2021 19:22

pepeiborra reviewed Jan 8, 2021

View reviewed changes

Comment thread .github/workflows/test.yml

pepeiborra reviewed Jan 8, 2021

View reviewed changes

Comment thread .github/workflows/test.yml Outdated

pepeiborra reviewed Jan 8, 2021

View reviewed changes

pepeiborra approved these changes Jan 8, 2021

View reviewed changes

Ailrun approved these changes Jan 8, 2021

View reviewed changes

Ailrun added the merge me Label to trigger pull request merge label Jan 9, 2021

jneira added a commit to jneira/haskell-language-server that referenced this pull request Jan 11, 2021

Remove runs dropped by haskell#1173

ec2c668

The mergify config is not completely updated and is required to remove them to unblock haskell#1173

jneira mentioned this pull request Jan 11, 2021

Remove runs dropped by #1173 #1194

Merged

jneira added a commit that referenced this pull request Jan 11, 2021

Merge pull request #1194 from jneira/remove-old-checks

16aee6e

Remove runs dropped by #1173

jneira added 10 commits January 11, 2021 09:18

Only test last ghc minor version

6356550

Set dirs for windows cabal cache

21f8273

Correct restore-key expression

e449ac3

Update hackage index

e2f55c3

Be strict in the restore cache key

ecf1781

Drop macOS tests

19bc1f1

Update tested-with GHC in cabal config

82db60a

Remove ghc-lib from test conditions

7779b1c

Restore restore-keys

1b3dd7c

Update mergify checks

8f888c2

jneira force-pushed the fix-win-cache branch from 7a75f91 to 8f888c2 Compare January 11, 2021 09:05

jneira merged commit fde10fa into haskell:master Jan 11, 2021

fendor pushed a commit to fendor/haskell-language-server that referenced this pull request Jan 11, 2021

Remove runs dropped by haskell#1173

ce8ca81

The mergify config is not completely updated and is required to remove them to unblock haskell#1173

jneira deleted the fix-win-cache branch January 15, 2021 06:50

jneira removed the merge me Label to trigger pull request merge label Jan 15, 2021

	if: ${{ !matrix.ghc-lib && matrix.test }}
	if: ${{ matrix.test }}

Uh oh!

Uh oh!

Conversation

jneira commented Jan 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jneira commented Jan 8, 2021

Uh oh!

Uh oh!

Uh oh!

pepeiborra Jan 8, 2021

Choose a reason for hiding this comment

Uh oh!

pepeiborra Jan 8, 2021

Choose a reason for hiding this comment

Uh oh!

pepeiborra left a comment

Choose a reason for hiding this comment

Uh oh!

Ailrun left a comment

Choose a reason for hiding this comment

Uh oh!

Ailrun commented Jan 10, 2021

Uh oh!

Ailrun commented Jan 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jneira commented Jan 11, 2021

Uh oh!

jneira commented Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jneira commented Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ailrun commented Jan 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jneira commented Jan 8, 2021 •

edited

Loading

Ailrun commented Jan 10, 2021 •

edited

Loading

jneira commented Jan 11, 2021 •

edited

Loading

jneira commented Jan 11, 2021 •

edited

Loading