Enforce max completions over all plugins#1256
Merged
Merged
Conversation
ndmitchell
approved these changes
Jan 24, 2021
pepeiborra
force-pushed
the
max-completions-hls
branch
from
January 24, 2021 21:03
7a80bb1 to
a7189af
Compare
pepeiborra
force-pushed
the
max-completions-hls
branch
from
January 24, 2021 21:17
a7189af to
35c0365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1218 I introduced a
maxCompletionsconfig setting, and added code to enforce it in ghcide.This PR applies the max completions limit to all plugins, not just ghcide. While doing this I noticed that the pragmas plugin was producing completions without considering the prefix, this is fixed now.