Restore code actions order#1273
Merged
Merged
Conversation
An unfortunate side effect of recent changes is that the extend import suggestions ended up at the bottom of the list
konn
reviewed
Jan 30, 2021
konn
reviewed
Jan 30, 2021
jneira
reviewed
Jan 30, 2021
jneira
left a comment
Member
There was a problem hiding this comment.
maybe add some tests about the ordering would be great, to not break it (relative between different kinds of?)
Collaborator
Author
Such tests would require adjustment every time a new code action is added, an existing code action is changed, etc. So I'm not keen on adding them, some tests are more trouble than they're worth. But if anyone else wants to do it, I won't oppose either. |
Member
|
we could check at least the preferred ones are below the cut limit, but definitely not in this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unfortunate side effect of recent changes is that the extend import suggestions ended up at the bottom of the list.
This change puts back all code actions provider together so they can be reordered more easily, and restores the previous order where extend imports would be near the top of the list