Skip to content

hls-splice-plugin-0.3.0.0-prepare#1311

Merged
konn merged 1 commit into
0.9.0-hackagefrom
hls-splice-plugin-0.3.0.0-prepare
Feb 5, 2021
Merged

hls-splice-plugin-0.3.0.0-prepare#1311
konn merged 1 commit into
0.9.0-hackagefrom
hls-splice-plugin-0.3.0.0-prepare

Conversation

@konn

@konn konn commented Feb 5, 2021

Copy link
Copy Markdown
Collaborator

As raised in #1287, current uploaded version of hls-splice-plugin-0.2.0.0 contradicts with the uploaded veresion of ghcide-0.7.3.0.

Since the code of hls-splice-plugin contained in 0.9.0-hackage compiles with ghcide-0.7.3.0 (I confirmedIt with ghc 8.8) and same functionality as in 0.9.0, just updating cabal file would suffice.

@konn
konn requested a review from jneira February 5, 2021 11:40
@konn

konn commented Feb 5, 2021

Copy link
Copy Markdown
Collaborator Author

After this gets merged into 0.9.0-hackage branch and another one confirms that it compiles with Hackage versions of packages, I will upload hls-splice-0.3.0.0 to Hackage.
To make the version in hls-splice-plugins consistent, I will also file another PR against the master .

@jneira jneira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@konn
konn merged commit ae6b541 into 0.9.0-hackage Feb 5, 2021
@konn
konn deleted the hls-splice-plugin-0.3.0.0-prepare branch February 5, 2021 12:14
@jneira

jneira commented Feb 5, 2021

Copy link
Copy Markdown
Member

I've checked that git checkout 0.9.0-hackage && cabal build hls-splice-plugin works so the release should work as the versions of hls-plugin-api and ghcide are from that branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants