Skip to content

[benchmarks] speed up CI#1315

Merged
konn merged 8 commits into
masterfrom
bench-parallel-gc
Feb 7, 2021
Merged

[benchmarks] speed up CI#1315
konn merged 8 commits into
masterfrom
bench-parallel-gc

Conversation

@pepeiborra

@pepeiborra pepeiborra commented Feb 6, 2021

Copy link
Copy Markdown
Collaborator
  • Disable parallel GC as it leads to occasional segfaults when combined with heap profiling
  • Lower the frequency of heap profiles to speed up benchmarks (I'll make it configurable in a follow-up change)
  • Reduce samples from 100 to 50 to speed up benchmarks

While I was there I also changed some of the artefact file extensions for consistency

…mutator

Heap census is preceded by a GC pass. The default interval of 0.1 seconds causes
the mutator time to go down to 14% in the HLS example
benchmark-gcStats was such an odd extension
@pepeiborra pepeiborra changed the title Speed up benchmarks [benchmarks] speed up CI Feb 6, 2021
Comment thread shake-bench/src/Development/Benchmark/Rules.hs

@jneira jneira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thans for improve ci times

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Feb 6, 2021
@pepeiborra

Copy link
Copy Markdown
Collaborator Author

I thought that the benchmark job was the bottleneck, but I've sent 3 PRs today and they are all still in the CircleCI queue after >7h ....

@konn

konn commented Feb 7, 2021

Copy link
Copy Markdown
Collaborator

Seems mergify got stuck, as its condition still requires bench for 8.8.4 and 8.10.2, not only for 8.10.3.

@konn
konn merged commit e7a75c1 into master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Label to trigger pull request merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants