Prepare 1.0.0 release#1402
Conversation
|
I support this move. I think we should also use this opportunity to start strictly adhering to PVP (https://pvp.haskell.org/) in an attempt to solve the problems we are facing with plugin bounds. In particular, this would involve putting upper bounds on the |
|
ghcide and hls-plugin-api have failed to adhere to the PVP in the past. Mea culpa, unintentionally. Hopefully it can be avoided in the future. Some automation would help!
|
|
@fendor suggested https://github.com/kowainik/policeman/ to check PVP compliance. |
|
In issue #1403, a bug with latest hie-bios has been uncovered. I am fixing it in haskell/hie-bios#283 but would ask to wait with this release until next |
|
OK, let's wait till that fix is released & introduced into HLS. |
|
EDIT: |
|
The Changelog looks really, really nice, many thanks. Afaics there are two alternatives to manage versions:
Usually i am inclined to follow pvp, but i have to recognize that the first one is very simple, dont even need automation and you identify the release in a quick look for any package. |
jneira
left a comment
There was a problem hiding this comment.
The Changelog is perfect.
However, i would bump up plugins before the release (whatever way we choose), to not have to do a branch 1.0.0-hackage and cherry-pick changes in cabal files (it caused problems last time)
|
In addition, I think it's time to update nixpkgs to ghc 8.10.4, like 8de2ca5 did |
The 1.0 proposal simplifies things, but because there may be ghcide and plugin releases in between big HLS releases, you also need both fixed bounds ( Moreover, we still need to address the coordination problem of uploading all plugins to Hackage. |
|
If we are gonna do hackage releases of subpackages between monthly releases we would need So what about bump up all packages to 1.0 and all bounds to 1.0.* right now? |
|
Maybe we should mention that new hie-bios use a dedicated build dir for cabal so it would fix the continual rebuilds: https://github.com/mpickering/hie-bios/blob/master/ChangeLog.md#2021-01-29---073 |
233c18c to
a10f6c6
Compare
jneira
left a comment
There was a problem hiding this comment.
lgtm, thanks for your thorough work 🙂
As mentioned in #1310 (comment), we consider releasing the major 1 version of HLS (and maybe plugins?)
This PR currently bumps only HLS, but if we decide to do so, I will bump other plugins too.Now this PR bumps all versions including GHCIDE.