Add kind and preferred flag for all Wingman code actions#1499
Conversation
|
This seems to be a success; I've managed to bind the code actions in my editor. What a great improvement! |
|
Nice! My only quibble is with |
|
Fair enough. I was thinking about case split when I named them, which does sorta inline the definition. But I'd prefer to have a common prefix for all of the actions, so maybe just |
|
|
|
|
||
| mkTacticKind :: TacticCommand -> CodeActionKind | ||
| mkTacticKind = | ||
| CodeActionUnknown . mappend "refactor.wingman." . tacticKind |
There was a problem hiding this comment.
I'm not familiar to action kind things, but since tactics plugin resolves (or changes) some errors, it may be better to use quickfix.wingman.. WDYT?
CC: @michaelpj
There was a problem hiding this comment.
Too slow, sorry! Feel free to file a bug if this is terribly worrisome!
There was a problem hiding this comment.
They don't seem very quickfix-y to me, and I think a bunch of them work with holes, so they won't actually be fixing errors.
There was a problem hiding this comment.
@michaelpj I mean a hole produces a compile error, so... But I'm not strongly inclined to anything :)
#1458 suggests that Wingman export its code actions with descriptive LSP kinds so that editors can more easily filter them. This PR does that, under the
refactor.wingman.prefix.@TOTBWF @michaelpj please review. Does this do what you want?