Eval plugin: evaluate expressions as statements#1603
Merged
Conversation
pepeiborra
approved these changes
Mar 21, 2021
Collaborator
Author
|
All test cases on Windows are failing: Perhaps an encoding-related issue? |
Member
|
@berberman mmm, i think you will have to save the file using utf-8, not sure how being in a evaluated expression, see haskell-language-server/plugins/hls-hlint-plugin/src/Ide/Plugin/Hlint.hs Lines 399 to 403 in b9c6e6c (maybe you will not need the newline thing) There is a function in the |
Collaborator
Author
|
Never mind, I found it might be caused by the backslash was not escaped properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1577
#438 introduced an alternative way to evaluate expressions: we wrapped expressions with
asPrint, and then usedcompileExprto get the coerced resultIO String. However, it broke functionality ofitvariable -- referencing the last evaluated result.This PR restores the old eval plugin's behaviour: there is no special treatment for expressions anymore; instead, expressions are just statements, and we redirect the output of
execStmtto a temporary file to get the same result ascompileExpr.